Log error output when a git command fails #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Jan 13, 2025
There was a problem hiding this comment.
I like the idea/implementation,
I'm worried that this will hide stderr when executing a command via the UI though
(as in the err output will no longer show unless the command fails at the end, and it will only show at the end)
so for that case we should still interleave the stderr ?
That's very true. I will focus the proposal. |
orien
force-pushed
the
error-output
branch
2 times, most recently
from
1c68eb1 to
ba5d318
Compare
orien
changed the title
orien
force-pushed
the
error-output
branch
2 times, most recently
from
d8da3a4 to
98a8a40
Compare
grosser
approved these changes
Jan 14, 2025
|
super clean solution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #3738. This time focusing on just the class that directs stderr to /dev/null: the
GitRepositoryclass.