Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Potential issue on master - after merging #276 #285

Closed
michalbundyra opened this issue Nov 28, 2017 · 2 comments
Closed

Potential issue on master - after merging #276 #285

michalbundyra opened this issue Nov 28, 2017 · 2 comments
Milestone
2.9.0

Comments

@michalbundyra
Copy link
Member

As noted to @ezimuel on Slack we have potential issue here:
bef0d5a#diff-1b78954777bbbf9668cb36aef77507c2R248 in case of else (after merging PR #276).

It should be verified by unit tests and fixed.

/cc @remicollet
@ezimuel ezimuel added this to the 2.9.0 milestone Nov 28, 2017
@remicollet
Copy link
Contributor

I don't think we can have something else than an aray or a string.

So I deliberately keep this missing else, but feel free to improve

@ezimuel
Copy link
Contributor

ezimuel commented Nov 28, 2017

@remicollet this means we can replace elseif (condition) with a simple else?

@michalbundyra michalbundyra mentioned this issue Nov 30, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

No branches or pull requests
3 participants
@remicollet @ezimuel @michalbundyra