This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Hotfix #285 #287
Merged
Hotfix #285 #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It bring back the previous functionality https://wiki.php.net/rfc/counting_non_countables Calling `count()` on a scalar or object that doesn't implement the Countable interface returns 1. (This behaviour has been changed in PHP 7.2)
It is not possible to have there Countable element. Please note it was not even imported so it was not working at all.
|
I was getting this warning message in PHP 7.2 |
|
@shaunfreeman the fix will be released with 2.9.0, probably soon :) |
|
@webimpress thanks! @shaunfreeman we'll release 2.9.0 next week. |
ezimuel
added a commit
that referenced
this pull request
Nov 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've checked and changing to
elseis good enough solution. Even if we have there non-string type it's gonna work as before, see:https://wiki.php.net/rfc/counting_non_countables\
Removed also part of the condition to check if variable is instance of Countable. It is not possible in that place. Please note the condition was wrong and not even working because
Countablewas not imported.Resolves #285
/cc @ezimuel @remicollet