This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
#192 spaces in order function #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… spaces, but ignores the fact that extra spaces are still there.
Ocramius
suggested changes
Jan 5, 2017
| @@ -651,7 +651,7 @@ protected function processOrder(PlatformInterface $platform, DriverInterface $dr | |||
| $v = self::ORDER_ASCENDING; | |||
| } | |||
| } | |||
| if (strtoupper($v) == self::ORDER_DESCENDING) { | |||
| if (strtoupper(trim($v)) == self::ORDER_DESCENDING) { | |||
There was a problem hiding this comment.
Is there any guarantee that $v is already uppercase?
There was a problem hiding this comment.
No, this is directly from input $select->order('col_name desc') or 'col_name DESC'. That said, case should not matter here just to find if defaults should be applied, so I will switch to case insensitive comparison.
| @@ -400,6 +400,13 @@ public function testOrder() | |||
| $this->assertEquals(['name ASC', 'age DESC'], $select->getRawState('order')); | |||
|
|
|||
| $select = new Select; | |||
| $select->order('name DESC'); | |||
There was a problem hiding this comment.
This should be in a new test, not added to the same test.
… proper string comparison.
|
@alextech thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #192 processing of ORDER BY correctly splits by multiple spaces, but ignores the fact that extra spaces are still there.