This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Allow null $parameters in Predicate::expression() #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zend\Db\Sql\Predicate\Expression::__construct() allows nulls for the $valueParameter, but this method that passes the parameter through does not allow nulls, so you have to explicitly pass null. Instead, in Zend\Db\Sql\Predicate\Predicate::expression(), the $parameters parameter should allow nulls.
|
@HillTravis can you create a unit test for this? I have actually had this issue before which I could see this being useful. |
|
@mwillbanks I added a unit test. I'm not sure why the Travis CI build is failing or why coverage would have decreased with the ADDITION of a unit test, but I ran the tests in my fork and everything passed. |
|
@HillTravis The failure is a coding standards check... and one that we just fixed on another PR. I'll review now. Thanks! |
weierophinney
added a commit
that referenced
this pull request
Sep 22, 2015
Allow null $parameters in Predicate::expression()
weierophinney
added a commit
that referenced
this pull request
Sep 22, 2015
weierophinney
added a commit
that referenced
this pull request
Sep 22, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zend\Db\Sql\Predicate\Expression::__construct() allows nulls for the
$valueParameter, but this method that passes the parameter through does not allow nulls, so you have to explicitly pass null. Instead, in Zend\Db\Sql\Predicate\Predicate::expression(), the$parametersparameter should allow nulls.