This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Hotfix #291 - Allowed param names with : at the beginning
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP supports binding params with `:` and without. As we add it always we should strip it out first before checking the name with regular expression, and add it at the end.
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
Hotfix #291 - Allowed param names with `:` at the beginning
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
Forward port #292 Conflicts: CHANGELOG.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP supports binding params with
:and without. As we add it alwayswe should strip it out first before checking the name with regular
expression, and add it at the end.
Resolves #291
@TakeoO @GreedyBytes can you please this solution with your code? Thanks
/ping @ezimuel
Are you fixing a bug?
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Is this related to quality assurance?