Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Test AbstractResultSet::current() to return null on empty array #313

Closed

Conversation

samsonasik
Copy link
Contributor

This is based on @rzjack comment at #303 (comment)

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?
  • Detail how the bug is invoked currently.
    initialize AbstractResultSet with empty array.
  • Detail the original, incorrect behavior.
    The AbstractResultset::current() return [].
  • Detail the new, expected behavior.
    The AbstractResultset::current() return null.
  • Base your feature on the master branch, and submit against that branch.
  • Add a regression test that demonstrates the bug, and proves the fix.
  • Add a CHANGELOG.md entry for the fix.

@samsonasik samsonasik changed the title Fix AbstractResultSet::current() to return null on empty array Test AbstractResultSet::current() to return null on empty array Apr 24, 2018
@samsonasik samsonasik closed this Apr 24, 2018
@samsonasik
Copy link
Contributor Author

@rzjack I can't reproduce issue with the test at AbstractResultSet::current() with initialize with empty array.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant