This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Fix undefined variable bug in MetadataFeature #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xerkus
commented
Oct 18, 2018
| } else { | ||
| $primaryKey = $pkc; | ||
| $primaryKey = $pkcColumns; |
There was a problem hiding this comment.
Original line had $pkc->getColumns() here: 1ac578f#diff-ca8362b8be8f02af0316d9c0e3979808L80
16 tasks
|
@Xerkus thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug introduced in #315
It was not released and exists only in master/develop branches as such no changelog entry is needed.
This PR restores original behavior, adds tests and reapplies changes from #315 properly.
Bug is invoked when metadata information is recorded into shared data of the TDG metadata feature
Undefined variable error is thrown and invalid data is written into shared data
Proper behavior restored, column name or list of columns in primary key are written into shared data
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.Supersedes #340