Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

add support for BLOB data in OCI8 driver #396

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

parktrip
Copy link

  • add 2 new data types in ParameterContainer class in order to manage differently BLOB from CLOB,
  • for oci8 driver: add a new case statement in bindParametersFromContainer() method to save data binded as BLOB

@michalbundyra
Copy link
Member

@parktrip thanks for your contribution. We need also test cases added to cover changes.
Also rebase will be required before merging (develop) as you are targeting develop branch.

@parktrip
Copy link
Author

dear @webimpress,
I have added test cases for oci8 and my changes.
I have 2 problems:

  • in Oci8FixtureLoader class I am trying to init db with data from oci8.sql, I got an ORA-00911 error line 62. I have checked the file and if I run it directly in sql+ it is working. My dba checked as wel and didn't see any potential problem
  • i don't know what to put in oracle_fixtures.sh as I don't have the knowledge on how to create the schema from scratch in command line.

Nevertheless, test cases for oci8 run fine ;)

@michalbundyra
Copy link
Member

@parktrip thanks for update, we can have a look on it closer before we merge it.
I can't promise when does it happen, I have it on my list but there are more PRs which need my attention before release.

@parktrip
Copy link
Author

dear @webimpress, I just took 5mn this morning to check travis error logs and it seems the oci_pconnect() function is not recognized. Are you sure the oci8 extension is activated in travis config file for all php versions ?

@michalbundyra
Copy link
Member

@parktrip it might be not enabled, but you can change it in .travis.yml.
Sorry, I haven't had time to have a look on it yet, so I'd appreciate a lot if you can investigate it more and update Travis CI configuration if needed. Thanks!

@parktrip
Copy link
Author

no pb I understand. I will have a look a little bit later hopefully by the end of the week

@michalbundyra michalbundyra added this to the 2.11.0 milestone Dec 31, 2019
… differently BLOB from CLOB,

- for oci8 driver: add a new case statement in bindParametersFromContainer() method to save data binded as BLOB
…other drivers,

- created 3 test cases to test the blob/clob implementation
@michalbundyra
Copy link
Member

@parktrip I've tried to update it and run it on travis but it seems to be uncompleted.
We would need to address when we move to Laminas (as it is gonna happen very soon).

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#2.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-db to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-db.
  • In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants