This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Implement FeatureSet canCallMagicCall and callMagicCall methods #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, I was attempting to call the lastSequenceId method of the SequenceFeature, after adding the SequenceFeature to a TableGateway object. However, on doing so, I discovered that both methods effectively weren't implemented, despite what the manual alluded to. Given that I'm adding this commit, along with the covering tests to implement the functionality.
| @@ -77,4 +78,93 @@ public function testAddFeatureThatFeatureHasTableGatewayButFeatureSetDoesnotHas( | |||
| $featureSet = new FeatureSet; | |||
| $this->assertInstanceOf('Zend\Db\TableGateway\Feature\FeatureSet', $featureSet->addFeature($feature)); | |||
| } | |||
|
|
|||
| /** | |||
| * @cover FeatureSet::canCallMagicCall | |||
There was a problem hiding this comment.
@covers instead of @cover , also, use fully namespaced class, @covers Zend\Db\TableGateway\Feature\FeatureSet::canCallMagicCall
There was a problem hiding this comment.
Thanks for that. I should have picked that up sooner. Perhaps I should go to bed as it's nearly 2am.
| use Zend\Db\TableGateway\Feature\MetadataFeature; | ||
| use Zend\Db\Metadata\Object\ConstraintObject; | ||
| use \ReflectionClass; |
There was a problem hiding this comment.
no more "", also, sort it before "Z"
|
ping @ralphschindler |
mwillbanks
added a commit
that referenced
this pull request
Dec 9, 2015
Implement FeatureSet canCallMagicCall and callMagicCall methods
mwillbanks
added a commit
that referenced
this pull request
Dec 9, 2015
mwillbanks
added a commit
that referenced
this pull request
Dec 9, 2015
|
Thanks @mwillbanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, I was attempting to call the lastSequenceId method of the
SequenceFeature, after adding the SequenceFeature to a TableGateway
object. However, on doing so, I discovered that both methods effectively
weren't implemented, despite what the manual alluded to. Given that I'm
adding this commit, along with the covering tests to implement the
functionality.