-
Notifications
You must be signed in to change notification settings - Fork 196
Conversation
Fixes #109 |
@@ -5,6 +5,6 @@ | |||
{"Container Factories": "factories.md"}, | |||
{"Using zend-servicemanager": "zend-servicemanager.md"}, | |||
{"Using Pimple": "pimple.md"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing ,
before next line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch.
] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, new line for end of file, a blank line after }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsonasik No blank line at the end of the file, please!!!!
My principal suggestion is that you follow the same patterns used for the ZF2 service manager and Pimple: in other words, have a |
@weierophinney question : Do you think changing to use Aura\Di\ContainerBuilder;
$container_builder = new ContainerBuilder();
// use the builder to create and configure a container
// using an array of ContainerConfig classes
$di = $container_builder->newConfiguredInstance([
'Application\_Config\Common',
]);
return $di; and having a seprate class is acceptable? The things are you can load other config classes if they are already provided by the package and don't need to add the config our own. <?php
chdir(dirname(__DIR__));
$container = require 'config/services.php';
$app = $container->get('Zend\Expressive\Application');
$app->run(); If this is acceptable let me know. |
Absolutely; that's exactly how we handled the other two, and why I
|
Have made the changes @weierophinney . Hope you like. Feel free to make the necessary changes. Thank you. |
|
||
The bare minimal `ContainerConfig ` code needed to make zend-expressive work is | ||
|
||
```php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should this class file be placed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming src/_Config/Common.php
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally in config
, and add autoload to composer.json . See skelton https://github.com/harikt/expressive-aura-skelton/blob/bbbbf233170ee4b76877860d676116f44f1d75d2/composer.json#L11 .
No description provided.