This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Eliminate deprecation notices due to request/response decorator usage #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are deprecated starting with Stratigility 1.3. This patch updates the `TemplatedErrorHandler` and the `WhoopsErrorHandler` to instead use the request `getOriginal*` attributes, which are injected in the Stratigility request/response decorators, and which can be injected by the `OriginalMessages` middleware as well. Additionally, this updates the `Application::run()` method to ensure that the `originalResponse` attribute is injected, as it is not in earlier Stratigility versions.
With updates from previous commit, no more error handling is required, as no deprecation notices are emitted.
Removes import statements for the Stratigility request/response decorators, as they are no longer used.
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
weierophinney
added a commit
that referenced
this pull request
Nov 11, 2016
Forward port #393 Conflicts: CHANGELOG.md src/Application.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does the following:
TemplatedErrorHandlerandWhoopsErrorHandlerto no longer use Stratigility request/response decorator-specific methods. Instead, they now pull values via theoriginal*request attributes, using default values.Application::run()method to set theoriginalResponserequest attribute; this allows the above changes to be used with Stratigility versions prior to 1.3 (which is the first release in which that attribute was introduced).Other than the error handling deprecations, this now allows Expressive to run without deprecation notices.