This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Make PHP error handler operate in a stack #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per zendframework#400, when we register a new error handler to swallow deprecation notices in `Application::__invoke()`, if any global error handlers were registered previously, they now disappear. This patch adds a test covering that scenario, and updates the `Application` class as follows: - The `set_error_handler()` call in `Application::__invoke()` has been replaced with a call to a new method, `swallowDeprecationNotices()`. - `swallowDeprecationNotices()` now captures the return value of calling `set_error_handler()`; if that value is non-empty, it creates a new error handler closing over its own error handler and the previous which invokes the previous if our own returns false.
- added `@todo` annotation to `swallowDeprecationNotices()` to ensure we remove it for 2.0.0. - updated `@todo` annotation for `__invoke()` to reference `swallowDeprecationNotices()` invocation - tightened up logic in `swallowDeprecationNotices()` to remove temporary variables.
weierophinney
added a commit
that referenced
this pull request
Dec 7, 2016
weierophinney
added a commit
that referenced
this pull request
Dec 7, 2016
Forward port #402 Conflicts: CHANGELOG.md src/Application.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #400, when we register a new error handler to swallow deprecation notices in
Application::__invoke(), if any global error handlers were registered previously, they now disappear.This patch adds a test covering that scenario, and updates the
Applicationclass as follows:set_error_handler()call inApplication::__invoke()has been replaced with a call to a new method,swallowDeprecationNotices().swallowDeprecationNotices()now captures the return value of callingset_error_handler(); if that value is non-empty, it creates a new error handler closing over its own error handler and the previous which invokes the previous if our own returns false.This serves as an alternate solution to #401.