This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Added handling for missing container/router in AppFactory #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unable to test, because both classes are always present in our test suite! - One tests for `$container` absence, and lack of `ServiceManager` - One tests for `$router` absence, and lack of `Router\FastRouteRouter`
- Updated to docheader 0.1.5, and imported regexp from feature/programmatic branch.
weierophinney
added a commit
that referenced
this pull request
Dec 8, 2016
Forward port #403 Conflicts: composer.json composer.lock
weierophinney
added a commit
that referenced
this pull request
Dec 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppFactory::createnow raises a newMissingDependencyExceptionin either ofthe two following scenarios:
$containerabsence, and lack ofServiceManager$routerabsence, and lack ofRouter\FastRouteRouterNote: I was unable to write tests, because both classes are always present in our test suite!
Fixes #352