This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Ensure invokable, duck-typed, class-based interop middleware works #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on an issue reported by @robertbasic. He reported that when you compose invokable class-based middleware that duck-types the `MiddlewareInterface`, Expressive raises an error; further, this only happens if the middleware is not composed in the container. This patch proposes a test case for that scenario.
Adds logic to `MarshalMiddlewareTrait::marshalInvokableMiddleware()` to wrap callable interop middleware in a `CallableInteropMiddlewareWrapper` instead of a `CallableMiddlewareWrapper`. Doing so highlighted a problematic test in `MarshalMiddlewareTraitTest` as well, which has now been corrected.
robertbasic
approved these changes
Mar 13, 2017
weierophinney
added a commit
that referenced
this pull request
Mar 13, 2017
weierophinney
added a commit
that referenced
this pull request
Mar 13, 2017
weierophinney
added a commit
that referenced
this pull request
Mar 13, 2017
…velop Forward port #467 Conflicts: CHANGELOG.md
weierophinney
deleted the
hotfix/robertbasic-callable-interop-middleware
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using invokable, class-based, duck-typed interop middleware that NOT composed in the DI container,
MarshalMiddlewareTrait::marshalInvokableMiddlewarewas incorrectly wrapping this in aCallableMiddlewareWrapperinstead of aCallableInteropMiddlewareWrapper; when such middleware was invoked, it was thus incorrectly being passed a response instead of a delegate, leading to a fatal error.This patch adds a unit test to validate usage, and fixes an incorrect test in the process.
Fixes an issue reported by @robertbasic.