This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
Provides more robust is_callable logic #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a new method, `IsCallableInteropMiddlewareTrait::isCallable()`, which runs its argument through `is_callable()`. If the value passes, it then checks to see if it is an array, and, if so, if: - the first argument is an object or valid class name, AND - the second argument is a valid method of the first argument. This is done because `is_callable()` returns a false positive when a two-element array is passed where the first argument is an object and the second a string; the function does not verify that the second element is a valid method of the first.
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
…evelop Forward port #534 Conflicts: test/ApplicationTest.php
weierophinney
deleted the
hotfix/527-pipe-with-something-looking-callable
branch
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
weierophinney
added a commit
that referenced
this pull request
Dec 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a new method,
IsCallableInteropMiddlewareTrait::isCallable(), which runs its argument throughis_callable(). If the value passes, it then checks to see if it is an array, and, if so, if:This is done because
is_callable()returns a false positive when a two-element array is passed where the first argument is an object and the second a string; the function does not verify that the second element is a valid method of the first.Fixes #527