This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Using http_build_query for application/x-www-form-urlencoded #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] Do not break http standard if wrong separator is set
Update Client.php
|
Update on when this will be merged into master @weierophinney ? Anytime I run composer update, I have to manually update this file. |
ezimuel
added a commit
to ezimuel/zend-http
that referenced
this pull request
Aug 4, 2016
|
@ameoba32 please merge ameoba32#3 that contains the unit test for your PR. |
|
I added the unit test during the merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By standard "&" character is used for application/x-www-form-urlencoded submissions. If separator is set to different value via ini_set('arg_separator.output', 'some other'); it will break http client with wrong request.
I suggest to hardcode "&" there