Translate Captcha into Dutch #25
Conversation
|
@weierophinney @Maks3w It would be super nice, if that could get merged and make it into a 2.5.3 release. 🙏 |
|
@Ocramius maybe? |
|
We need a dutch speaking person to reviewing it. @mmoll can you confirm the translations? (Okay, Munich… 😉 ) |
|
@froschdesign I'm a native Dutch speaker in case that helps, but I wouldn't mind a review from someone else :) |
I already see this at your GitHub profile, but it would be good if someone can confirm your translations. Two-man rule – in this case two dutch speaking persons. |
languages/nl/Zend_Captcha.php
Outdated
| return [ | ||
| // Zend\Captcha\ReCaptcha | ||
| "Missing captcha fields" => "Missende captcha velden", | ||
| "Failed to validate captcha" => "Captcha validatie mislukt", |
There was a problem hiding this comment.
Maybe not necessary since the english counterpart misses the has too, it's kind of robot speak in english also.
There was a problem hiding this comment.
Both could work, but since I don't use Zend (@mmoll asked me to translate) I don't know the context where it's used. I also considered Ongeldige captcha validatie or some version of that, but I tried to stay close to the English translation.
There was a problem hiding this comment.
Nah, what you have in the PR now is way better than Ongeldige captcha validatie.
|
👍 from a dutch person. |
languages/nl/Zend_Captcha.php
Outdated
|
|
||
| // Zend\Captcha\Word | ||
| "Empty captcha value" => "Lege captcha waarde", | ||
| "Captcha ID field is missing" => "Captcha ID veld mist", |
There was a problem hiding this comment.
I'd say "Captcha ID veld is niet aanwezig"
There was a problem hiding this comment.
"niet aanwezig" or "afwezig"?
There was a problem hiding this comment.
I'm changing it to ontbreekt
languages/nl/Zend_Captcha.php
Outdated
| return [ | ||
| // Zend\Captcha\ReCaptcha | ||
| "Missing captcha fields" => "Missende captcha velden", | ||
| "Failed to validate captcha" => "Captcha validatie mislukt", |
|
@ekohl, @mmoll @frankdejonge and @derickr Great. Thank you for your help! 👍 |
languages/nl/Zend_Captcha.php
Outdated
|
|
||
| // Zend\Captcha\Word | ||
| "Empty captcha value" => "Lege captcha waarde", | ||
| "Captcha ID field is missing" => "Captcha ID veld mist", |
There was a problem hiding this comment.
Er mist een Captcha ID veld? Don't use Zend\Captcha so need a bit more context.
There was a problem hiding this comment.
Nevermind, I commented it earlier but send the review a bit later, see @derickr's discussion. I think the latter wins?
Edit: was refering to ekohl's comment, metalArend has an even better one. At the moment there is no comment after that (speaking about communication gaps).
asgrim
dismissed
their stale review
Removing my approval in light of ongoing discussion on translations :)
ekohl
force-pushed
the
dutch-captcha-translation
branch
from
79598f1 to
d6f27f6
Compare
|
When will this finally be merged? This is like 3 months old! C'mon now.. |
|
|
|
@mmoll this was my first merge to ZF, and as evidenced by the revert above, I screwed it up, I don't think I want to be screwing up releases just yet :D I'll leave it to someone more experienced for now heh |
|
@ekohl thanks for your contribution 👍 |
|
omg |
cc @mmoll