This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Ensure translator_plugins config is honored in non-zend-mvc contexts
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://discourse.zendframework.com/t/validatormanager-not-calling-custom-validator-factory/109/5?u=matthew the `translator_plugins` config key is not honored currently unless the application is within a zend-mvc context. This is due to the fact that `Zend\I18n\Module` wires configuration for the `Zend\ModuleManager\Listener\ServiceListener` in order to push merged service configuration into the plugin during bootstrap; no similar logic is available when not in a zend-mvc context, however. This patch fixes that situation by modifying the `LoaderPluginManagerFactory` to do the following: - If a `ServiceListener` service exists, it returns the plugin manager immediately (old behavior). - Otherwise, it checks for the `config` service, and, if found, a `translator_plugins` key with an array value. When found, it feeds that value to a `Zend\ServiceManager\Config` instance and uses that to configure the plugin manager before returning it.
|
Test failures are all on lowest, due to zend-servicemanager test expectation updates to use PHPUnit 5.7/6.0 expectException syntax within the |
weierophinney
added a commit
that referenced
this pull request
May 17, 2017
weierophinney
added a commit
that referenced
this pull request
May 17, 2017
weierophinney
added a commit
that referenced
this pull request
May 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://discourse.zendframework.com/t/validatormanager-not-calling-custom-validator-factory/109/5?u=matthew the
translator_pluginsconfig key is not honored currently unless the application is within a zend-mvc context. This is due to the fact thatZend\I18n\Modulewires configuration for theZend\ModuleManager\Listener\ServiceListenerin order to push merged service configuration into the plugin during bootstrap; no similar logic is available when not in a zend-mvc context, however.This patch fixes that situation by modifying the
LoaderPluginManagerFactoryto do the following:ServiceListenerservice exists, it returns the plugin manager immediately (old behavior).configservice, and, if found, atranslator_pluginskey with an array value. When found, it feeds that value to aZend\ServiceManager\Configinstance and uses that to configure the plugin manager before returning it.