This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
Fix type juggling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If $key is int with value 0, we have true result for condition. It's wrong.
| @@ -74,7 +74,7 @@ public function setOptions(array $options) | |||
| continue; | |||
| } | |||
|
|
|||
| if ($key == 'jsonrpc') { | |||
| if ('jsonrpc' == $key) { | |||
There was a problem hiding this comment.
This doesn't do what you think it does, a fact which is made clear when you add a test with the following:
$response->setOptions([0 => '2.0']);
Assert::assertNull($response->getVersion();The above is identical to the previous code; it just swaps the sides of the comparison. What is required is to switch to the strict equality operator, ===.
I've added a test, and updated the patch.
weierophinney
added a commit
that referenced
this pull request
Apr 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If $key is int with value 0, we have true result for condition. It's wrong.