Merge pull request zendframework/zendframework#7393 from samsonasik/i…

…mplement-todo-write-more-tests implements @todo write more tests for Zend\Ldap\Converter::toLdap()
zendframework · May 6, 2015 · 52fb2c0 · 52fb2c0
commit 52fb2c0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/Converter/Converter.php b/src/Converter/Converter.php
@@ -72,7 +72,6 @@ public static function hex32ToAsc($string)
      * By setting the <var>$type</var>-parameter the conversion of a certain
      * type can be forced
      *
-     * @todo write more tests
      *
      * @param mixed $value The value to convert
      * @param int   $type  The conversion type to use

diff --git a/test/Converter/ConverterTest.php b/test/Converter/ConverterTest.php
@@ -11,6 +11,7 @@
 
 use DateTime;
 use DateTimeZone;
+use stdClass;
 use Zend\Ldap\Converter\Converter;
 
 /**
@@ -136,7 +137,14 @@ public function toLdapProvider()
                                  'type' => 1)),
             array('19700101000000Z', array('value'=> DateTime::createFromFormat(DateTime::ISO8601, '1970-01-01T00:00:00+0000'),
                                            'type' => 0)),
-
+            array(Converter::toldapBoolean(true), array('value' => (bool) true,
+                                                        'type' => 0)),
+            array(Converter::toLdapSerialize(new stdClass()), array('value' => new stdClass(),
+                                                                    'type' => 0)),
+            array(Converter::toLdapSerialize(array('foo')), array('value' => array('foo'),
+                                                                  'type' => 0)),
+            array(stream_get_contents(fopen(__FILE__, 'r')), array('value' => fopen(__FILE__, 'r'),
+                                                                   'type' => 0)),
         );
     }