Merge pull request zendframework/zendframework#1909 from denixport/ho…

…tfix/math-tests Math\BigInteger better tests
zendframework · Jul 23, 2012 · b5ec01e · b5ec01e
commit b5ec01e
Show file tree

Hide file tree

Showing 7 changed files with 406 additions and 412 deletions.
diff --git a/src/BigInteger/Adapter/Bcmath.php b/src/BigInteger/Adapter/Bcmath.php
@@ -165,10 +165,7 @@ public function sqrt($operand)
      */
     public function abs($operand)
     {
-        if ('-' == $operand[0]) {
-            return substr($operand, 1);
-        }
-        return $operand;
+        return ltrim($operand, '-');
     }
 
     /**
@@ -183,7 +180,6 @@ public function mod($leftOperand, $rightOperand)
         return bcmod($leftOperand, $rightOperand);
     }
 
-
     /**
      * Raise a big integer to another, reduced by a specified modulus
      *

diff --git a/src/BigInteger/Adapter/Gmp.php b/src/BigInteger/Adapter/Gmp.php
@@ -50,7 +50,12 @@ public function init($operand, $base = null)
             }
         }
 
-        return gmp_strval(gmp_init($sign . $operand, $base));
+        $res = gmp_init($sign . $operand, $base);
+        if ($res === false) {
+            return false;
+        }
+
+        return gmp_strval($res);
     }
 
     /**