This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Fix (un)serialization for Reflection* objects - PHP 7.4 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
private properties of abstract class cannot be serialized on PHP versions prior to 7.4. Changed these properties to protected so we don't need to do anything extra on unserialization.
|
LGTM, thanks |
froschdesign
approved these changes
Oct 16, 2019
weierophinney
added a commit
that referenced
this pull request
Oct 16, 2019
…n-php-7.4 Fix (un)serialization for Reflection* objects - PHP 7.4
weierophinney
added a commit
that referenced
this pull request
Oct 16, 2019
weierophinney
added a commit
that referenced
this pull request
Oct 16, 2019
Forward port #30 Conflicts: CHANGELOG.md
|
Thanks, @webimpress |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
https://github.com/php/php-src/blob/php-7.4.0RC3/UPGRADING
Now in our objects we are storing internally declaring names (class name/function name/parameter name) so we can create reflection object on wakeup. Reflection object is not serialized, just the names.
/cc @remicollet