Merge branch 'weierophinney-hotfix/polyfill-via-class-alias' into dev…

…elop PR zendframework/zendframework#3966
zendframework · Mar 6, 2013 · 7c09779 · 7c09779
3 parents 79d9ad3 + 370a890 + 68a1766
commit 7c09779
Show file tree

Hide file tree

Showing 8 changed files with 104 additions and 88 deletions.
diff --git a/composer.json b/composer.json
@@ -10,10 +10,7 @@
     "autoload": {
         "psr-4": {
             "Zend\\Session\\": "src/"
-        },
-        "files": [
-            "Zend/Session/compatibility/autoload.php"
-        ]
+        }
     },
     "require": {
         "php": ">=5.3.3",

diff --git a/src/Container.php b/src/Container.php
@@ -9,6 +9,12 @@
 
 namespace Zend\Session;
 
+if (version_compare(PHP_VERSION, '5.3.4', 'lt')) {
+    class_alias('Zend\Session\AbstractContainer', 'Zend\Session\AbstractBaseContainer');
+} else {
+    class_alias('Zend\Session\Container\PhpReferenceCompatibility', 'Zend\Session\AbstractBaseContainer');
+}
+
 /**
  * Session storage container
  *
@@ -17,24 +23,6 @@
  * Additionally, expiries may be absolute TTLs or measured in "hops", which
  * are based on how many times the key or container were accessed.
  */
-class Container extends AbstractContainer
+class Container extends AbstractBaseContainer
 {
-    /**
-     * Retrieve a specific key in the container
-     *
-     * @param  string $key
-     * @return mixed
-     */
-    public function &offsetGet($key)
-    {
-        $ret = null;
-        if (!$this->offsetExists($key)) {
-            return $ret;
-        }
-        $storage = $this->getStorage();
-        $name    = $this->getName();
-        $ret =& $storage[$name][$key];
-
-        return $ret;
-    }
 }
diff --git a/src/Container/PhpReferenceCompatibility.php b/src/Container/PhpReferenceCompatibility.php
@@ -0,0 +1,37 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link      http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ */
+
+namespace Zend\Session\Container;
+
+use Zend\Session\AbstractContainer;
+
+/**
+ * Session storage container for PHP 5.3.4 and above.
+ */
+abstract class PhpReferenceCompatibility extends AbstractContainer
+{
+    /**
+     * Retrieve a specific key in the container
+     *
+     * @param  string $key
+     * @return mixed
+     */
+    public function &offsetGet($key)
+    {
+        $ret = null;
+        if (!$this->offsetExists($key)) {
+            return $ret;
+        }
+        $storage = $this->getStorage();
+        $name    = $this->getName();
+        $ret =& $storage[$name][$key];
+
+        return $ret;
+    }
+}
diff --git a/src/Storage/SessionArrayStorage.php b/src/Storage/SessionArrayStorage.php
@@ -9,30 +9,15 @@
 
 namespace Zend\Session\Storage;
 
+if (version_compare(PHP_VERSION, '5.3.4', 'lt')) {
+    class_alias('Zend\Session\Storage\AbstractSessionArrayStorage', 'Zend\Session\Storage\AbstractBaseSessionArrayStorage');
+} else {
+    class_alias('Zend\Session\Storage\SessionArrayStorage\PhpReferenceCompatibility', 'Zend\Session\Storage\AbstractBaseSessionArrayStorage');
+}
+
 /**
  * Session storage in $_SESSION
  */
-class SessionArrayStorage extends AbstractSessionArrayStorage
+class SessionArrayStorage extends AbstractBaseSessionArrayStorage
 {
-    /**
-     * Get Offset
-     *
-     * @param  mixed $key
-     * @return mixed
-     */
-    public function &__get($key)
-    {
-        return $_SESSION[$key];
-    }
-
-    /**
-     * Offset Get
-     *
-     * @param  mixed $key
-     * @return mixed
-     */
-    public function &offsetGet($key)
-    {
-        return $_SESSION[$key];
-    }
 }
diff --git a/src/Storage/SessionArrayStorage/PhpReferenceCompatibility.php b/src/Storage/SessionArrayStorage/PhpReferenceCompatibility.php
@@ -0,0 +1,40 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link      http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ */
+
+namespace Zend\Session\Storage\SessionArrayStorage;
+
+use Zend\Session\Storage\AbstractSessionArrayStorage;
+
+/**
+ * PHP 5.3.4 and greater variant of SessionArrayStorage
+ */
+abstract class PhpReferenceCompatibility extends AbstractSessionArrayStorage
+{
+    /**
+     * Get Offset
+     *
+     * @param  mixed $key
+     * @return mixed
+     */
+    public function &__get($key)
+    {
+        return $_SESSION[$key];
+    }
+
+    /**
+     * Offset Get
+     *
+     * @param  mixed $key
+     * @return mixed
+     */
+    public function &offsetGet($key)
+    {
+        return $_SESSION[$key];
+    }
+}
diff --git a/src/compatibility/Container.php b/src/compatibility/Container.php
diff --git a/src/compatibility/Storage/SessionArrayStorage.php b/src/compatibility/Storage/SessionArrayStorage.php
diff --git a/src/compatibility/autoload.php b/src/compatibility/autoload.php
@@ -1,11 +1,14 @@
 <?php
-if (version_compare(PHP_VERSION, '5.3.4', 'lt')) {
-    if (!class_exists('Zend\Stdlib\ArrayObject', false)
-        && file_exists(__DIR__ . '/../../Stdlib/compatibility/autoload.php')
-    ) {
-        require __DIR__ . '/../../Stdlib/compatibility/autoload.php';
-    }
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link      http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license   http://framework.zend.com/license/new-bsd New BSD License
+ * @deprecated
+ */
 
-    require_once __DIR__ . '/Container.php';
-    require_once __DIR__ . '/Storage/SessionArrayStorage.php';
-}
+/**
+ * Legacy purposes only, to prevent code that references it from breaking.
+ */
+trigger_error('Polyfill autoload support (file library/Zend/Session/compatibility/autoload.php) is no longer necessary; please remove your require statement referencing this file', E_USER_DEPRECATED);