This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Add isNotValid api #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't disagree with this. |
Maks3w
added a commit
to Maks3w/zend-validator
that referenced
this pull request
Jul 20, 2015
While this method does not apport new features it improves the expressiveness. credits @gianarb zendframework#23
|
I do disagree with this. More methods === more to support, and more to learn. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it's a good idea but I see a lot of this implementation
In my opinion this is difficult to read.
I know that a new api is an important upgrade but this is very easy to maintain and the code is more readable!
In this PR I have not added it into the Interface because it would be a big BC Break.. :)