Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Zend\Db\TableGateway: Alias for table #6726

Closed
Pittiplatsch opened this issue Oct 2, 2014 · 2 comments
Closed

Zend\Db\TableGateway: Alias for table #6726

Pittiplatsch opened this issue Oct 2, 2014 · 2 comments
Assignees
@Ocramius
Labels
bug Db
Milestone
2.3.4

Comments

@Pittiplatsch
Copy link

To use table gateway with joins, it's appropriate to alias the table gateway's base table as well. However, there's no possibility to alias the gateway's table the same way as accepted by regular Select.

Changing both
https://github.com/zendframework/zf2/blob/master/library/Zend/Db/TableGateway/TableGateway.php#L34
and
https://github.com/zendframework/zf2/blob/master/library/Zend/Db/TableGateway/AbstractTableGateway.php#L104
to accept Select's array alias notation works for me, but might introduce BC breaks for external classes (e.g. Features?) reading table property.
Pittiplatsch pushed a commit to Pittiplatsch/zf2 that referenced this issue Oct 7, 2014
Fix for Zend\Db\TableGateway: Alias for table zendframework#6726
9e5a2f5
@samsonasik
Copy link
Contributor

linked with PR #6740

@Ocramius Ocramius mentioned this issue Dec 16, 2014
Closed
@Ocramius Ocramius self-assigned this Dec 16, 2014
@Ocramius Ocramius added this to the 2.3.4 milestone Dec 16, 2014
Ocramius pushed a commit that referenced this issue Dec 16, 2014
@Ocramius
Fix for Zend\Db\TableGateway: Alias for table #6726
16f0be9
Ocramius added a commit that referenced this issue Dec 16, 2014
@Ocramius
#6726 #6740 - adding @group annotation for newly introduced tests
d4a42b3
Ocramius added a commit that referenced this issue Dec 16, 2014
@Ocramius
Merge branch 'hotfix/#6726-#6740-tablegateway-table-alias' into develop
b1969e7 
Close #6726
Close #6740
Forward port #6726
Forward port #6740
@Ocramius
Copy link
Member

Handled in #6740

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
bug Db
Projects
None yet
Milestone
2.3.4
Development

No branches or pull requests
3 participants
@Ocramius @samsonasik @Pittiplatsch