This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[2.1] Feature/overrideable di factories #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ory since it will only cause problems with cyclic dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new factories (and for the joy of the java fans we now have a
FactoryFactory!) to handle instantiation of Di related services in a better controllable way.Anyway, I found myself very often overriding complete factories, controller plugin managers, view helper managers, controller loaders (by completely duplicating code) because I couldn't override how Di and its factories work.
First note: I didn't yet try it out with my logic, so I'll remove the [WIP] from the subject as soon as I've verified that I can completely disable/enable Di in every Mvc part.
Second note: This PR introduces a minor PR I'm commenting on the code right now.