This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Use 'Router' in http env and 'HttpRouter' in cli #2400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The router should not be duplicated in HTTP, so the application's router and url view helper router must be the same. However, inside a cli env the url helper must have the HTTP router in order to assemble urls.
weierophinney
added a commit
to weierophinney/zendframework
that referenced
this pull request
Sep 21, 2012
- Test integration with MVC services, in particular console vs HTTP routers. - Required being able to override value of Console::isConsole(); added a $isConsole protected static member, and an overrideIsConsole($flag) public static method; if the flag is a boolean, its value will be returned via isConsole().
ghost
assigned
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
- Test integration with MVC services, in particular console vs HTTP routers. - Required being able to override value of Console::isConsole(); added a $isConsole protected static member, and an overrideIsConsole($flag) public static method; if the flag is a boolean, its value will be returned via isConsole().
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-console
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
- Test integration with MVC services, in particular console vs HTTP routers. - Required being able to override value of Console::isConsole(); added a $isConsole protected static member, and an overrideIsConsole($flag) public static method; if the flag is a boolean, its value will be returned via isConsole().
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The router should not be duplicated in HTTP, so the application's
router and url view helper router must be the same. However, inside
a cli env the url helper must have the HTTP router in order to
assemble urls.