This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
[WIP][Server] Rewrite Reflection API to reuse code from Zend\Code\Reflection API #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,16 +47,16 @@ public function getName() | |||
| public function initialize($tagDocBlockLine) | |||
| { | |||
| $matches = array(); | |||
| preg_match('#([\w|\\\]+)(?:\s+(\$\S+)){0,1}(?:\s+(.*))?#s', $tagDocBlockLine, $matches); | |||
| preg_match('#([\w|\\\]+(\[\])*)(?:\s+(\$\S+)){0,1}(?:\s+(.*))?#s', $tagDocBlockLine, $matches); | |||
There was a problem hiding this comment.
Add support for typed arrays like string[] or Object[][]
ghost
assigned 
Also remove underscore preffix from methods name
weierophinney
added a commit
that referenced
this pull request
Nov 1, 2012
- XmlRpc needed testing as it relies on Zend\Server\Reflection. Changes in recent versions of PHPUnit have made it more greedy with regards to warnings, which led to new test failures. The changes introduced make the component more resilient.
|
@weierophinney Why not merge this to master too? I tried to preserve the BC |
|
@Maks3w because of the signature changes, and the fact it added new On Friday, November 2, 2012, Maks wrote:
Matthew Weier O'Phinney |
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
- XmlRpc needed testing as it relies on Zend\Server\Reflection. Changes in recent versions of PHPUnit have made it more greedy with regards to warnings, which led to new test failures. The changes introduced make the component more resilient.
weierophinney
added a commit
to zendframework/zend-xmlrpc
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-server
that referenced
this pull request
May 15, 2015
- XmlRpc needed testing as it relies on Zend\Server\Reflection. Changes in recent versions of PHPUnit have made it more greedy with regards to warnings, which led to new test failures. The changes introduced make the component more resilient.
weierophinney
added a commit
to zendframework/zend-server
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-soap
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.