This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Select::where should accept PredicateInterface #2919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PredicateInterface can just be accepted "as-is" instead of requiring a single-key array...
|
Definitely a good idea. |
|
You should change Sql\Update and Sql\Where too. And the having() method . |
|
Please provide tests for the feature |
ghost
assigned 
|
I suspect this also needs to be applied to having() as well |
|
Your patch does not work, $pvalue is not defined. |
| @@ -239,6 +239,10 @@ public function where($predicate, $combination = Predicate\PredicateSet::OP_AND) | |||
| { | |||
| if ($predicate instanceof Where) { | |||
| $this->where = $predicate; | |||
| } elseif ($pvalue instanceof Predicate\PredicateInterface) { | |||
There was a problem hiding this comment.
I think $pvalue should be $predicate
|
I'll redo this and open up a new one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PredicateInterface can just be accepted "as-is" instead of requiring a single-key array...