This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Serializer #3
Closed
Serializer #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged into zf2 master -- thanks! |
ezimuel
referenced
this pull request
in ezimuel/zf2
Mar 2, 2012
- Tested Zend\Db\ResultSet\ResultSet, and fixed several logic errors, as well as completed implementation
padraic
added a commit
that referenced
this pull request
Jul 5, 2012
Feature: Use new escape view helpers in Zend\Form\View\Helper
ghost
mentioned this pull request
ghost
mentioned this pull request
Closed
This was referenced Jan 9, 2014
ezimuel
added a commit
to zendframework/zend-math
that referenced
this pull request
May 15, 2015
…feature/crypt Ezimuel/feature/crypt
ezimuel
added a commit
to zendframework/zend-crypt
that referenced
this pull request
May 15, 2015
…feature/crypt Ezimuel/feature/crypt
gianarb
pushed a commit
to zendframework/zend-cache
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…on-renamed-interfaces Thanks!
isisis
added a commit
to isisis/zf2
that referenced
this pull request
May 28, 2015
I think it's a common use case for the default navigation, to add pages and sub pages across many modules. There's currently an issue when adding sub pages to another page that you expect to be in configuration already. The main page could be changed to another name, could be removed or the module could be disabled inside an application architecture that uses ZF2 modules like plug-ins. What happens in this case? ------------------------------------------------------------- Fatal error: Uncaught exception 'Zend\Navigation\Exception\InvalidArgumentException' with message 'Invalid argument: Unable to determine class to instantiate' in /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/Page/AbstractPage.php:254 Stack trace: #0 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/AbstractContainer.php(114): Zend\Navigation\Page\AbstractPage::factory(Array) zendframework#1 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/AbstractContainer.php(165): Zend\Navigation\AbstractContainer->addPage(Array) zendframework#2 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/Navigation.php(35): Zend\Navigation\AbstractContainer->addPages(Array) zendframework#3 /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/Navigation/Service/AbstractNavigationFactory.php(38): Zend\Navigation\Navigation->__construct(Array) zendframework#4 [internal function]: Zend\Navigation\Service\AbstractNavigationFactory->createService(Obj in /var/www/html/ebonikerp/vendor/zendframework/zendframework/library/Zend/ServiceManager/ServiceManager.php on line 946 ------------------------------------------------------------- This fix solves the problem, by ignoring a main page, when it's missing uri or mvc values, and could be used as quick fix. For future I would like to see a validation for the pages configs, before they're being injected to navigation. Another approach could be to add a separate "navigation-extension" configuration beside the "navigation" configuration. The "navigation-extension" configuration could be used to extend the navigation safely. The NavigationFactory would then use only the configuration parts that already have a valid existing navigation entry inside "navigation" key.
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all tests of Zend/Serializer passed