This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
fix dispatcher to catch legitimate exceptions #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All service managers throw the same ServiceNotFound and ServiceNotCreated exceptions. The dispatcher made no distinctions between: * exceptions thrown in the event a controller can't be loaded; and * exceptions thrown from initializers within ControllerLoader The first case is a legitimate "controller-not-found" error and can be tested for using the "ServiceManager::has()" method whereas the second case needs to be caught and forwarded to a 500 status page.
|
I have one doubt: can you test this against a controller manager that composes an abstract factory, please? I have a vague recollection that has() does not query those, which is why we went the route we did. If that's no longer the case, I'll be happy to merge! |
|
@weierophinney done. I'm afraid unit testing is my weak spot, let me know if I missed any test cases. I also tested it with a sample project of my own. |
ghost
assigned
weierophinney
added a commit
that referenced
this pull request
Jan 14, 2013
- Indentation, trailing whitespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All service managers throw the same
ServiceNotFoundandServiceNotCreatedexceptions.The dispatcher made no distinctions between:
ControllerLoaderThe first case is a legitimate "controller-not-found" error and can be tested for using the
ServiceManager::has()method whereas the second case needs to be caught and forwarded to a 500 status page.