[Form] [FormElementManager] don't overwrite form factory if already set #3735
Conversation
|
Unit test? |
ghost
assigned 
| @@ -84,7 +84,7 @@ public function __construct(ConfigInterface $configuration = null) | |||
| public function injectFactory($element) | |||
| { | |||
| if ($element instanceof FormFactoryAwareInterface) { | |||
| $element->setFormFactory(new Factory($this)); | |||
| $element->getFormFactory()->setFormElementManager($this); | |||
There was a problem hiding this comment.
These are actually synonymous -- getFormFactory() will create a form factory instance internally. The old code is actually more performant than your change as it bypasses the getter and immediately sets a new instance that has the element manager composed. (The reason no unit tests fail currently is because we actually have a test that verifies that the form element manager is identical in the two objects.)
Can you indicate why you would want to alter this? A unit test detailing the use case would make the most sense, as right now, I'm unclear what the purpose of the change is.
There was a problem hiding this comment.
Actually, your subject line details it: you want to inject the element manager into an existing factory, if present.
- Test demonstrates that factory composed by object implementing FormFactoryAwareInterface is not overwritten, but *is* injected with FormElementManager instance.
|
Added a unit test on merge. |
Don't overwrite factory in case other initializers are called beforehand that set the form factory, or attach an input filter factory to it.