This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Remove Identical validator type hint #6592
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type hint was introduced in 7bcd59a and causes PHP errors when passing in ArrayObject context parameters. Remove the type hint and make sure the passed context is either an array or an ArrayObject instance.
|
NOTE: The BC Break here is to fix a prior BC break that caused this issue to happen. |
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
…es invalid cases one by one instead
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
Ocramius
added a commit
that referenced
this pull request
Nov 22, 2014
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…`ArrayObject` instances for `$context`
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…ipped: data provider executes invalid cases one by one instead
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
gianarb
pushed a commit
to zendframework/zend-validator
that referenced
this pull request
May 15, 2015
…ator-array-hint-removal' into develop Close zendframework/zendframework#6592
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7bcd59a introduced an array type hint for the
$contextparameter inZend\Validator\Identical::isValid(). This causes PHP errors if the InputFilter containing the Identical validator is executed on form values (they are passed not as arrays, butZend\Stdlib\Parameters).Remove the type hint and add a check if
$contextisarrayorArrayObject.