This repository has been archived by the owner on May 16, 2018. It is now read-only.
Fix regexp to detect functions in column definition #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to #441 |
|
BTW. CLA signed |
|
ping @ezimuel |
|
Do we need this for 1.12.12 ? |
|
The unit tests looks good to me. |
|
@foxel this PR is related also to SQL statements group() and order(), we need to include also unit tests for these use cases. Can you add these tests? Thanks. |
|
Updated to include more tests |
|
Hi! |
foxel
force-pushed
the
columnQuotes
branch
2 times, most recently
from
7dd5c48 to
f1bce79
Compare
foxel
force-pushed
the
columnQuotes
branch
2 times, most recently
from
613434e to
f1bce79
Compare
None! (A review is needed. Thanks for the hint.) |
froschdesign
added a commit
that referenced
this pull request
May 21, 2015
Fix regexp to detect functions in column definition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed for unbalanced parentheses and deeply nested functions