feature/tutorials.navigations.rst

[GeeH]

Added new tutorial that explains how to add Zend\Navigation to the basic Album app.

[Freeaqingme]

I'd propose to either add a backslash between 'Zend' and 'Navigation', or change it to 'Adding navigation to your Album Module'

[GeeH]

Agreed

[GeeH]

Fixed

[Freeaqingme]

Review complete. Really nice addition to the docs!

[GeeH]

Thanks for the comprehensive review, apologies for the lack of proof reading after conversion. This is good to review again now Freeqy.

[GeeH]

I can't agree with that change, I'm aiming for consistency, it's confusing to have to define the key in navigation() for menu, and in the breadcrumb method for breadcrumbs, this way it's consistent across both helpers.

[froschdesign]

it's confusing to have to define the key in navigation() for menu, and in the breadcrumb method for breadcrumbs, this way it's consistent across both helpers.

???

You can use:

echo $this->navigation('navigation')->menu();
echo $this->navigation()->breadcrumbs();

or

echo $this->navigation('navigation')->menu();
echo $this->navigation('navigation')->breadcrumbs();

[GeeH]

Neither of these will work for breadcrumbs, the only way breadcrumbs work is to pass the container to the breadcrumbs method. This is why I'm passing the container name to the method in both breadcrumbs and menu. At the moment, it's at least consistent.

[froschdesign]

Neither of these will work for breadcrumbs, the only way breadcrumbs work is to pass the container to the breadcrumbs method.

2.1.4 is around the corner: zendframework/zendframework#3991

[GeeH]

So your saying I should write this for a version that isn't released just yet?

[froschdesign]

http://zend-framework-community.634137.n4.nabble.com/Code-freeze-for-2-1-4-td4659447.html

[GeeH]

Yep, I saw it, it doesn't change the point that as is, your proposed change won't work on the production version of ZF2.

[GeeH]

Is there a fix for this in 2.1.4? I may be being stupid but I can't see one looking at the history of the helpers :o

[froschdesign]

@Spabby
Please look at my previous comment with the link to #3991!

[GeeH]

I really should not be so snappy with people who are trying to be helpful, please accept my apologies, bad day. I will hold this PR to be merged until 2.1.4 and update the code accordingly once I've tested it :)

Thanks for the feedback.

[GeeH]

Standardised on $this->navigation('container')... thanks again for the feedback.