New Zend\Validator\Bitwise

[corentin-larose]

Usage:

<?php
use Zend\validator\Bitwise;

$execute    = 0x1;
$write      = 0x2;
$read       = 0x4;
$controlSum = 0x7; // 0x1 | 0x2 | 0x4 === 0x7

$validator = new Bitwise($controlSum, Bitwise::OP_AND, false);

// or
$validator = new Bitwise(array(
    'control'  => $controlSum,
    'operator' => Bitwise::OP_AND,
    'strict'   => false
));

// or
$validator = new Bitwise();
$validator->setControl($controlSum);
$validator->setOperator(Bitwise::OP_AND);
$validator->setStrict(false); // Default value, just for example

// Does my value has at least one allowed bit set ?
$validator = new Bitwise($controlSum, Bitwise::OP_AND, false);
$validator->isValid(0x1); // true
$validator->isValid(0x2); // true
$validator->isValid(0x4); // true
$validator->isValid(0x1 | 0x8); // true since strict option is set to false by default
$validator->isValid(0x8); // false

// Does my value has only allowed bits set ?
$validator = new Bitwise($controlSum, Bitwise::OP_AND, true);
$validator->isValid(0x1); // true
$validator->isValid(0x2); // true
$validator->isValid(0x4); // true
$validator->isValid(0x1 | 0x8); // false since strict option is set to true
$validator->isValid(0x8); // false

// Does my value has only not allowed bit sets ?
$validator = new Bitwise($controlSum, Bitwise::OP_XOR);
$validator->isValid(0x1); // false
$validator->isValid(0x2); // false
$validator->isValid(0x4); // false
$validator->isValid(0x1 | 0x8); // false
$validator->isValid(0x8); // true

[samsonasik]

remove @Package

[samsonasik]

it ( @Package ) need to be removed

[corentin-larose]

Sorry, missed this spot the first time !

[weierophinney]

If you do not have nested options (i.e., if the options are only one level deep), just use iterator_to_array here.

[weierophinney]

@corentin-larose Looks good - incorporate or answer the various feedback, and I'll review to merge.

[corentin-larose]

Ok, I will take your changes and commit again.

[corentin-larose]

@weierophinney should be ok/compliant if you want to merge.

[Maks3w]

@corentin-larose Your test are failing in Travis-CI

[concat] There were 12 errors:
[concat]
[concat] 1) ZendTest\Validator\BitwiseTest::testConstruct with data set #0 (array(), array(0, NULL, false))
[concat] Failed asserting that null is identical to 0.
[concat]
[concat] /home/travis/build/zendframework/zf2/tests/ZendTest/Validator/BitwiseTest.php:32
[concat]
[concat] 2) ZendTest\Validator\BitwiseTest::testConstruct with data set #1 (array(1), array(1, NULL, false))
[concat] Failed asserting that null is identical to 1.
[concat]
[concat] /home/travis/build/zendframework/zf2/tests/ZendTest/Validator/BitwiseTest.php:32
[concat]
[concat] 3) ZendTest\Validator\BitwiseTest::testConstruct with data set #2 (array(1, 'and'), array(1, 'and', false))
[concat] Failed asserting that null is identical to 1.
[concat]
[concat] /home/travis/build/zendframework/zf2/tests/ZendTest/Validator/BitwiseTest.php:32
[concat]
[concat] 4) ZendTest\Validator\BitwiseTest::testConstruct with data set #3 (array(1, 'and', true), array(1, 'and', true))
[concat] Failed asserting that null is identical to 1.
[concat]
[concat] /home/travis/build/zendframework/zf2/tests/ZendTest/Validator/BitwiseTest.php:32
[concat]
[concat] 5) ZendTest\Validator\BitwiseTest::testConstruct with data set #4 (array(1), array(1, NULL, false))
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::isvalid".
[concat]
[concat]
[concat] 6) ZendTest\Validator\BitwiseTest::testConstruct with data set #5 (array(1, 'and'), array(1, 'and', false))
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::isvalid".
[concat]
[concat]
[concat] 7) ZendTest\Validator\BitwiseTest::testConstruct with data set #6 (array(1, 'and', true), array(1, 'and', true))
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::isvalid".
[concat]
[concat]
[concat] 8) ZendTest\Validator\BitwiseTest::testBitwiseAndNotStrict
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::isvalid".
[concat]
[concat]
[concat] 9) ZendTest\Validator\BitwiseTest::testBitwiseAndStrict
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::isvalid".
[concat]
[concat]
[concat] 10) ZendTest\Validator\BitwiseTest::testBitwiseXor
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::isvalid".
[concat]
[concat]
[concat] 11) ZendTest\Validator\BitwiseTest::testSetOperator
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::setOperator".
[concat]
[concat]
[concat] 12) ZendTest\Validator\BitwiseTest::testSetStrict
[concat] PHP_CodeCoverage_Exception: Trying to @cover not existing method "Bitwise::setStrict".

[corentin-larose]

@Maks3w, my bad, fixed the constructor to work the same way than other validators, forgot to push the U.T

[Maks3w]

@corentin-larose Tests run still failing.

[corentin-larose]

Tests are ok, seems that Travis didn't run the most recent code (possible ?) I'm running tests on my last commit: 9339412.

corentin@QAPA-I:/media/localhost/zf2-fork/tests$ phpunit ZendTest/Validator/BitwiseTest.php
PHPUnit 3.7.24 by Sebastian Bergmann.

Configuration read from /media/localhost/zf2-fork/tests/phpunit.xml

.........

Time: 0 seconds, Memory: 3.00Mb

OK (9 tests, 48 assertions)

[Maks3w]

@corentin-larose Please read the log and make the necessary to changes for to have a clean Travis-CI run. If you see the log Travis use even a most recent version than you.

Try using full namespace class name instead the just Bitwise in that anotations.

[corentin-larose]

@Maks3w doc block fixed, travis still fails, but on the usual think which is not related with Bitwise validator.