Fix for Zend\Db\TableGateway: Alias for table #6726 #6740

Pittiplatsch · 2014-10-07T22:26:51Z

No description provided.

malukenho · 2014-10-10T18:13:50Z

I think its need test.

Pittiplatsch · 2014-10-10T19:18:53Z

Here they are :)

samsonasik · 2014-10-17T16:37:49Z

library/Zend/Db/TableGateway/TableGateway.php

@@ -31,7 +31,7 @@ class TableGateway extends AbstractTableGateway
    public function __construct($table, AdapterInterface $adapter, $features = null, ResultSetInterface $resultSetPrototype = null, Sql $sql = null)
    {
        // table
-        if (!(is_string($table) || $table instanceof TableIdentifier)) {
+    	if (!(is_string($table) || $table instanceof TableIdentifier || is_array($table))) {


revert this left indentation cs : the indentation already right.

Ocramius · 2014-12-16T07:21:06Z

Linking #6726

Close #6726 Close #6740 Forward port #6726 Forward port #6740

Ocramius · 2014-12-16T07:23:08Z

Merged, thanks @Pittiplatsch!

master: f60b322
develop: b1969e7

Fix for Zend\Db\TableGateway: Alias for table zendframework#6726

9e5a2f5

Add unit test passing all possible variants of table identifier

f5a15c5

samsonasik reviewed Oct 17, 2014
View reviewed changes

Fix spacing

eff0414

samsonasik mentioned this pull request Oct 18, 2014

Zend\Db\TableGateway: Alias for table #6726

Closed

Ocramius added Db enhancement labels Dec 11, 2014

Ocramius added this to the 2.4.0 milestone Dec 11, 2014

Ocramius self-assigned this Dec 11, 2014

Ocramius added bug and removed enhancement labels Dec 16, 2014

Ocramius added a commit that referenced this pull request Dec 16, 2014

#6726 #6740 - adding @group annotation for newly introduced tests

d4a42b3

Ocramius closed this in f60b322 Dec 16, 2014

Ocramius added a commit that referenced this pull request Dec 16, 2014

Merge branch 'hotfix/#6726-#6740-tablegateway-table-alias' into develop

b1969e7

Close #6726 Close #6740 Forward port #6726 Forward port #6740

Pittiplatsch deleted the gateway_table_alias branch January 15, 2015 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for Zend\Db\TableGateway: Alias for table #6726 #6740

Fix for Zend\Db\TableGateway: Alias for table #6726 #6740

Pittiplatsch commented Oct 7, 2014

malukenho commented Oct 10, 2014

Pittiplatsch commented Oct 10, 2014

samsonasik Oct 17, 2014

Ocramius commented Dec 16, 2014

Ocramius commented Dec 16, 2014

Fix for Zend\Db\TableGateway: Alias for table #6726 #6740

Fix for Zend\Db\TableGateway: Alias for table #6726 #6740

Conversation

Pittiplatsch commented Oct 7, 2014

malukenho commented Oct 10, 2014

Pittiplatsch commented Oct 10, 2014

samsonasik Oct 17, 2014

Choose a reason for hiding this comment

Ocramius commented Dec 16, 2014

Ocramius commented Dec 16, 2014