fix docment about fee point #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
reviewed
Feb 7, 2023
Comment on lines
+497
to
+498
| /// 0 means that all exchange fees belong to the liquidity provider. | ||
| /// 30 means that all exchange fees belong to the fee receiver. |
There was a problem hiding this comment.
This is still incorrect, a value of 0 actually gives all fees to the fee receiver. A higher value simply limits the total cut of the exchange fee given to the fee receiver, therefore an upper bound of 30 is not required.
There was a problem hiding this comment.
With the current code, it seems intuitive that fee_receiver earns more when fee_point=30 than when fee_point=10. So can you use unit tests to corroborate your point？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.