Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the snapshot workflow with product key and product repo for docs deployments #156

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

alourie
Copy link
Contributor

@alourie alourie commented Jan 9, 2024

Description

Updating the snapshot workflow with product key and product repo for docs deployments

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
    - [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
    - [ ] I have commented my code in any hard-to-understand or hacky areas.
    - [ ] I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

- [ ] I have updated the changelog.
- [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

@ryanjcoleman
Copy link
Member

@alourie alourie requested a review from kgreav January 9, 2024 15:01
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 49 lines in your changes are missing coverage. Please review.

Comparison is base (43fae8a) 90.28% compared to head (d84529a) 92.67%.
Report is 118 commits behind head on main.

Files Patch % Lines
...evolve/database/sqlite/readers/NetworkCIMReader.kt 92.15% 0 Missing and 12 partials ⚠️
...61968/infiec61968/infassetinfo/CurrentRelayInfo.kt 66.66% 6 Missing and 1 partial ⚠️
...lve/cim/iec61970/base/wires/PowerTransformerEnd.kt 81.25% 0 Missing and 6 partials ⚠️
.../evolve/cim/iec61970/base/core/IdentifiedObject.kt 50.00% 1 Missing and 4 partials ⚠️
...m/zepben/evolve/cim/iec61970/base/core/NameType.kt 88.57% 0 Missing and 4 partials ⚠️
...en/evolve/database/sqlite/upgrade/UpgradeRunner.kt 86.66% 0 Missing and 4 partials ⚠️
...om/zepben/evolve/database/sqlite/DatabaseWriter.kt 72.72% 0 Missing and 3 partials ⚠️
...evolve/cim/iec61970/base/wires/PowerTransformer.kt 75.00% 0 Missing and 2 partials ⚠️
...om/zepben/evolve/database/sqlite/DatabaseReader.kt 93.93% 1 Missing and 1 partial ⚠️
...evolve/cim/iec61970/base/wires/RegulatingCondEq.kt 75.00% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #156      +/-   ##
============================================
+ Coverage     90.28%   92.67%   +2.39%     
- Complexity     3755     4542     +787     
============================================
  Files           419      441      +22     
  Lines          9811    12320    +2509     
  Branches       1280     1422     +142     
============================================
+ Hits           8858    11418    +2560     
- Misses          502      518      +16     
+ Partials        451      384      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kgreav kgreav force-pushed the EWB-4180-update-snapshot-builds branch from 1d651fd to d84529a Compare January 11, 2024 09:58
@kgreav kgreav merged commit e0b46db into main Jan 11, 2024
5 checks passed
@kgreav kgreav deleted the EWB-4180-update-snapshot-builds branch January 11, 2024 10:06
kgreav pushed a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants