Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-2209] Support NetworkState for getEquipmentContainer #200

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

clydeu
Copy link
Member

@clydeu clydeu commented Jan 9, 2025

Description

Support NetworkState for NetworkConsumerClient.getEquipmentContainer.

Associated tasks

None

Test Steps

N/A

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • [ ] I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

Not a breaking change.

@ryanjcoleman
Copy link
Member

Task linked: DEV-2209 Update JVM SDK

@clydeu clydeu marked this pull request as ready for review January 9, 2025 02:27
@clydeu clydeu requested review from charlta and kgreav January 9, 2025 02:27
changelog.md Outdated Show resolved Hide resolved
@charlta charlta marked this pull request as draft January 9, 2025 22:25
Signed-off-by: clydeu <[email protected]>
@clydeu clydeu marked this pull request as ready for review January 13, 2025 07:07
@clydeu clydeu requested a review from charlta January 13, 2025 07:08
@clydeu clydeu marked this pull request as draft January 13, 2025 07:09
@clydeu clydeu marked this pull request as ready for review January 13, 2025 07:18
Signed-off-by: Anthony Charlton <[email protected]>
@charlta charlta merged commit 5470ffa into main Jan 14, 2025
3 checks passed
@charlta charlta deleted the DEV-2209-support-networkstate-for-getequipmentcontainer branch January 14, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants