Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base docker tag to maven:3.9.8-amazoncorretto-11-al2023 #45

Closed
wants to merge 8 commits into from

Conversation

zarakay
Copy link
Member

@zarakay zarakay commented Jul 12, 2024

Description

Full context here https://zepben.slack.com/archives/GAHA1BEGL/p1720763255524979

We updated the actions/checkout@v4 which depends on a newer version of node, which in turn depends on a newer version of glibc.

It seems the image we were using was basically EOL since it was build off Amazon Linux 2. The newer images are all tagged -al2023 which stands for Amazon Linux 2023 which has all the newer things since its actually kept up to date.

Associated tasks

N/A

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members if so.

Please leave a summary of the breaking changes here. This is useful for the reviewer, but also is useful for communication to the team when merged (e.g. you could copy and paste the summary into slack).

Screenshots

Remove this section if the change cannot be shown through screenshots. Frontend changes should mostly include this section.
Screenshots can be copy-pasted into Github textboxes and a link will automatically be generated.
Remove this text if you choose to use this section.

Before After
image image

@zarakay zarakay marked this pull request as draft July 12, 2024 06:18
@zarakay
Copy link
Member Author

zarakay commented Jul 25, 2024

This has been solved separately

@zarakay zarakay closed this Jul 25, 2024
@zarakay zarakay deleted the update-to-newer-image branch July 25, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant