Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1134 - Fix default value detection with Reflection #2225

Merged
merged 9 commits into from
Apr 21, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Apr 20, 2021

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

ReflectionParameter:isDefaultValueAvailable() now returns correct value when array has default value.

Thanks

@Jeckerson Jeckerson added the bug label Apr 20, 2021
@Jeckerson Jeckerson added this to the 0.13.3 milestone Apr 20, 2021
@Jeckerson Jeckerson requested a review from AlexNDRmac April 20, 2021 21:21
@Jeckerson Jeckerson self-assigned this Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2225 (fae1b2e) into development (ccc60f3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##             development   #2225      +/-   ##
================================================
- Coverage           7.71%   7.70%   -0.01%     
- Complexity          8682    8684       +2     
================================================
  Files                355     355              
  Lines              21971   21992      +21     
================================================
  Hits                1694    1694              
- Misses             20277   20298      +21     

@AlexNDRmac AlexNDRmac merged commit cc2e91a into development Apr 21, 2021
@AlexNDRmac AlexNDRmac deleted the #1134-reflection-default-value branch April 21, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection isDefaultValueAvailable() method seems to not work as expected
2 participants