Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fat_fs: Add support for the "win" variable alignment in FATFS struct #9

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fat_fs: Add support for the "win" variable alignment in FATFS struct #9

merged 1 commit into from
Jan 21, 2022

Conversation

ngboonkhai
Copy link
Contributor

This is to support Sypnosys Designware SDMMC controller read and write
operation where the buffer address is needed to be 16bytes and 512bytes
aligned. Adding macro FS_FATFS_WIN_ALIGN to align the "win" variable
address in FATFS struct.

Signed-off-by: Boon Khai Ng [email protected]

@de-nordic de-nordic mentioned this pull request Dec 13, 2021
Merged
@ngboonkhai
Copy link
Contributor Author

Hi all,
I tried to find the add reviewer button but no luck :( .
Refer to previous PR, I saw your name reviewing the ffconf.h, hence adding you all and need your help to review this PR
@pabigot
@de-nordic
@carlescufi
@nashif

Regards,
Boon Khai

@ngboonkhai
Copy link
Contributor Author

Hi @de-nordic @carlescufi ,

I'm still pending review for this PR, can you please help to review?

Regards,
Boon Khai

@ngboonkhai
Copy link
Contributor Author

Hi @de-nordic @carlescufi

Any updates?

Regards,
Boon Khai

de-nordic
de-nordic reviewed Dec 22, 2021
View reviewed changes
include/ff.h Outdated Show resolved Hide resolved
@carlescufi
Copy link
Member

@ngboonkhai we don't really have any additional mantainers besides @de-nordic. As soon as he approves we can merge this, but remember that you need to create a PR to the main zephyr repo as described here:
https://docs.zephyrproject.org/latest/guides/modules.html#process-for-submitting-changes-to-existing-modules

de-nordic
de-nordic reviewed Dec 23, 2021
View reviewed changes
include/ffconf.h Outdated Show resolved Hide resolved
@ngboonkhai
Copy link
Contributor Author

@ngboonkhai we don't really have any additional mantainers besides @de-nordic. As soon as he approves we can merge this, but remember that you need to create a PR to the main zephyr repo as described here: https://docs.zephyrproject.org/latest/guides/modules.html#process-for-submitting-changes-to-existing-modules

Okay noted carlescufi. Will work closely with Ermel.

@ngboonkhai ngboonkhai force-pushed the add-memory-alignment-option branch from a2f2976 to 32f6bef Compare December 26, 2021 03:30
@ngboonkhai
Copy link
Contributor Author

Hi Ermel,

Done force push the PR with the update that align with our discussion. Please check.

Regards,
Boon Khai.

de-nordic
de-nordic approved these changes Dec 30, 2021
View reviewed changes
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Thanks!

@ngboonkhai
Copy link
Contributor Author

Looks OK. Thanks!

Thanks @de-nordic :D

@ngboonkhai
Copy link
Contributor Author

@carlescufi
Hi Carles,

Please help me to merge the PR, Thanks

Regards,
Boon Khai

@de-nordic
Copy link
Collaborator

@carlescufi Hi Carles,

Please help me to merge the PR, Thanks

Regards, Boon Khai

@ngboonkhai Please address my issue here zephyrproject-rtos/zephyr#41096 (comment)

@ngboonkhai
Copy link
Contributor Author

@carlescufi Hi Carles,
Please help me to merge the PR, Thanks
Regards, Boon Khai

@ngboonkhai Please address my issue here zephyrproject-rtos/zephyr#41096 (comment)

Hi @de-nordic

Done force push, Thanks

Regards,
Boon Khai

@de-nordic
Copy link
Collaborator

@carlescufi This already passes tests with Zephyr manifest, so please review.

@de-nordic
Copy link
Collaborator

@carles @galak @nashif, anyone please review. We need second review for this.

@ngboonkhai
fat_fs: Add support for the "win" variable alignment in FATFS struct
196cad9 
This is to support Sypnosys Designware SDMMC controller read and write
operation where the buffer address is needed to be 16bytes and 512bytes
aligned. Adding macro FS_FATFS_WINDOW_ALIGNMENT to align the "win"
variable address in FATFS struct.

Signed-off-by: Boon Khai Ng <[email protected]>
@ngboonkhai ngboonkhai force-pushed the add-memory-alignment-option branch from 32f6bef to 196cad9 Compare January 21, 2022 06:01
@de-nordic de-nordic merged commit 9237454 into zephyrproject-rtos:master Jan 21, 2022
@ngboonkhai
Copy link
Contributor Author

Thanks @de-nordic, @nvlsianpu !

@ngboonkhai ngboonkhai deleted the add-memory-alignment-option branch February 22, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@de-nordic de-nordic de-nordic approved these changes

@nvlsianpu nvlsianpu nvlsianpu approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngboonkhai @carlescufi @de-nordic @nvlsianpu