Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newlib to v3.3 + zephyr + xtensa patches #258

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

galak
Copy link
Contributor

@galak galak commented Jul 22, 2020

No description provided.

@galak
Copy link
Contributor Author

galak commented Jul 23, 2020

@dcpleung can you look at the failure on x86_64 build w/newlib-3.3:

https://buildkite.com/zephyr/sdk-ng/builds/123#ec5651a1-edb6-479e-91e9-b7de20b8c780

@dcpleung
Copy link
Member

Given the error message, it seems like newlib is using the wrong machine directory (using machine/x86_64 instead of machine/i386 for building 32-bit libraries).

@dcpleung
Copy link
Member

Your latest update to add CT_EXPERIMENTAL=y should work. Without it, crosstool-ng reverts to using 3.1 tarball, and not using the git repo.

@galak
Copy link
Contributor Author

galak commented Jul 23, 2020

Your latest update to add CT_EXPERIMENTAL=y should work. Without it, crosstool-ng reverts to using 3.1 tarball, and not using the git repo.

Thanks, made that update and running through CI now.

@dcpleung
Copy link
Member

I just built x86_64-zephyr-elf locally and it worked after adding CT_EXPERIMENTAL.

Just one thing, the newlib repo is missing the patch from commit commit f73e8b5
(x86_64: newlib: use march=pentium for 32-bit). This one is needed for 32-bit x86.

@galak galak force-pushed the fix-newlib-cfg branch 2 times, most recently from 1e745b0 to 63f3a1a Compare August 11, 2020 12:01
@galak
Copy link
Contributor Author

galak commented Aug 11, 2020

@dcpleung would appreciate your testing on xtensa with this PR. I think this should supersede #257. Has the nicety of now unifying the xtensa newlib with all other arch's.

@dcpleung
Copy link
Member

@dcpleung would appreciate your testing on xtensa with this PR. I think this should supersede #257. Has the nicety of now unifying the xtensa newlib with all other arch's.

Do you have a link to the built toolchain?

@galak
Copy link
Contributor Author

galak commented Aug 11, 2020

Do you have a link to the built toolchain?

builds.zephyrproject.org/zephyrproject-rtos/sdk-ng/258/zephyr-sdk-0.11.4-pr-258-x86_64-linux-setup.run

@dcpleung
Copy link
Member

I have run the new SDK again intel_s1000_crb and up_squared_adsp on a few apps, since I don't have the setup to do automatic sanitycheck. I explicitly tested tests/application_development/libcxx and the kernel *_api tests. Apps that worked before continue working, and broken ones are still broken. So I think this is good to go in terms of Xtensa.

@galak galak merged commit 04bfc60 into zephyrproject-rtos:master Sep 11, 2020
@galak galak deleted the fix-newlib-cfg branch September 11, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants