Skip to content

Commit

Permalink
tests: openthread: Fix build warnings
Browse files Browse the repository at this point in the history 
Fix build warnings from llvm/clang build.

Fixes #30328

Signed-off-by: Robert Lubos <[email protected]>
  • Loading branch information
@rlubos @nashif
rlubos authored and nashif committed Dec 3, 2020
1 parent bae2c58 commit c2ae579
Showing 1 changed file with 33 additions and 16 deletions.
49 changes: 33 additions & 16 deletions tests/subsys/openthread/radio_test.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -423,13 +423,15 @@ static void test_tx_test(void)

zassert_not_null(frm, "Transmit buffer is null.");

otPlatRadioSetTransmitPower(ot, power);
zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE,
"Failed to set TX power.");

ztest_returns_value(set_channel_mock, 0);
ztest_expect_value(set_channel_mock, channel, chan);
ztest_expect_value(set_txpower_mock, dbm, power);
ztest_expect_value(start_mock, dev, &radio);
otPlatRadioReceive(ot, chan);
zassert_equal(otPlatRadioReceive(ot, chan), OT_ERROR_NONE,
"Failed to receive.");

/* ACKed frame */
frm->mChannel = chan2;
Expand Down Expand Up @@ -490,11 +492,15 @@ static void test_tx_power_test(void)
{
int8_t out_power = 0;

otPlatRadioSetTransmitPower(ot, -3);
otPlatRadioGetTransmitPower(ot, &out_power);
zassert_equal(otPlatRadioSetTransmitPower(ot, -3), OT_ERROR_NONE,
"Failed to set TX power.");
zassert_equal(otPlatRadioGetTransmitPower(ot, &out_power),
OT_ERROR_NONE, "Failed to obtain TX power.");
zassert_equal(out_power, -3, "Got different power than set.");
otPlatRadioSetTransmitPower(ot, -6);
otPlatRadioGetTransmitPower(ot, &out_power);
zassert_equal(otPlatRadioSetTransmitPower(ot, -6), OT_ERROR_NONE,
"Failed to set TX power.");
zassert_equal(otPlatRadioGetTransmitPower(ot, &out_power),
OT_ERROR_NONE, "Failed to obtain TX power.");
zassert_equal(out_power, -6,
"Second call to otPlatRadioSetTransmitPower failed.");
}
Expand Down Expand Up @@ -570,24 +576,29 @@ static void test_source_match_test(void)
sys_put_le16(12345, ext_addr.m8);
set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, false,
true);
otPlatRadioAddSrcMatchShortEntry(ot, 12345);
zassert_equal(otPlatRadioAddSrcMatchShortEntry(ot, 12345),
OT_ERROR_NONE, "Failed to add short src entry.");


for (int i = 0; i < sizeof(ext_addr.m8); i++) {
ext_addr.m8[i] = i;
}
set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, true,
true);
otPlatRadioAddSrcMatchExtEntry(ot, &ext_addr);
zassert_equal(otPlatRadioAddSrcMatchExtEntry(ot, &ext_addr),
OT_ERROR_NONE, "Failed to add ext src entry.");

/* Clear */
sys_put_le16(12345, ext_addr.m8);
set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, false,
false);
otPlatRadioClearSrcMatchShortEntry(ot, 12345);
zassert_equal(otPlatRadioClearSrcMatchShortEntry(ot, 12345),
OT_ERROR_NONE, "Failed to clear short src entry.");

set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, ext_addr.m8, true,
false);
otPlatRadioClearSrcMatchExtEntry(ot, &ext_addr);
zassert_equal(otPlatRadioClearSrcMatchExtEntry(ot, &ext_addr),
OT_ERROR_NONE, "Failed to clear ext src entry.");

set_expected_match_values(IEEE802154_CONFIG_ACK_FPB, NULL, false,
false);
Expand Down Expand Up @@ -724,7 +735,8 @@ static void test_radio_state_test(void)
const uint8_t channel = 12;
const uint8_t power = 10;

otPlatRadioSetTransmitPower(ot, power);
zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE,
"Failed to set TX power.");
zassert_equal(otPlatRadioDisable(ot), OT_ERROR_NONE,
"Failed to disable radio.");

Expand All @@ -748,7 +760,8 @@ static void test_radio_state_test(void)
ztest_expect_value(set_channel_mock, channel, channel);
ztest_expect_value(set_txpower_mock, dbm, power);
ztest_expect_value(start_mock, dev, &radio);
otPlatRadioReceive(ot, channel);
zassert_equal(otPlatRadioReceive(ot, channel), OT_ERROR_NONE,
"Failed to receive.");
zassert_equal(platformRadioChannelGet(ot), channel,
"Channel number not remembered.");

Expand Down Expand Up @@ -834,13 +847,15 @@ static void test_receive_test(void)
net_pkt_set_ieee802154_lqi(packet, lqi);
net_pkt_set_ieee802154_rssi(packet, rssi);

otPlatRadioSetTransmitPower(ot, power);
zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE,
"Failed to set TX power.");

ztest_returns_value(set_channel_mock, 0);
ztest_expect_value(set_channel_mock, channel, channel);
ztest_expect_value(set_txpower_mock, dbm, power);
ztest_expect_value(start_mock, dev, &radio);
otPlatRadioReceive(ot, channel);
zassert_equal(otPlatRadioReceive(ot, channel), OT_ERROR_NONE,
"Failed to receive.");

/*
* Not setting any expect values as nothing shall be called from
Expand Down Expand Up @@ -873,13 +888,15 @@ static void test_net_pkt_transmit(void)
/* success */
len = alloc_pkt(&packet, 2, 'a');
buf = packet->buffer;
otPlatRadioSetTransmitPower(ot, power);
zassert_equal(otPlatRadioSetTransmitPower(ot, power), OT_ERROR_NONE,
"Failed to set TX power.");

ztest_returns_value(set_channel_mock, 0);
ztest_expect_value(set_channel_mock, channel, channel);
ztest_expect_value(set_txpower_mock, dbm, power);
ztest_expect_value(start_mock, dev, &radio);
otPlatRadioReceive(ot, channel);
zassert_equal(otPlatRadioReceive(ot, channel), OT_ERROR_NONE,
"Failed to receive.");

notify_new_tx_frame(packet);

Expand Down

0 comments on commit c2ae579

Please sign in to comment.