Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCUMGR_LOG build error #15713

Closed
lgl88911 opened this issue Apr 28, 2019 · 3 comments · Fixed by apache/mynewt-mcumgr#96
Closed

MCUMGR_LOG build error #15713

lgl88911 opened this issue Apr 28, 2019 · 3 comments · Fixed by apache/mynewt-mcumgr#96
Assignees
Labels
area: Device Management area: Logging Enhancement Changes/Updates/Additions to existing features

Comments

@lgl88911
Copy link
Collaborator

Describe the bug
when I config CONFIG_MCUMGR_CMD_LOG_MGMT=y, mcumgr log will build error:

error 1: create makefile fail:

Cannot find source file:
/home/frank/work/project/westzephyr/zephyr/ext/lib/mgmt/mcumgr/cmd/log_mgmt/cmd/log_mgmt/port/zephyr/src/zephyr_log_mgmt.c

I fix it by modify zephyr/ext/lib/mgmt/mcumgr/cmd/log_mgmt/CMakeLists.txt

target_include_directories(MCUMGR INTERFACE 
    include
)

zephyr_library_sources(
    port/zephyr/src/zephyr_log_mgmt.c
    src/log_mgmt.c
    src/stubs.c
)

then disapper
error 2 can't find file:

/home/frank/work/project/westzephyr/zephyr/ext/lib/mgmt/mcumgr/cmd/log_mgmt/port/zephyr/src/zephyr_log_mgmt.c:21:10: fatal error: logging/mdlog.h: No such file or directory
 #include <logging/mdlog.h>

I search zephyr path & west path, can't find mdlog, but it be used by zephyr_log_mgmt.c.
It's a bug? or I config have some error?
Please give me some suggest, thanks!

@lgl88911 lgl88911 added the bug The issue is a bug, or the PR is fixing a bug label Apr 28, 2019
@carlescufi
Copy link
Member

That file doesn't seem to have ever existed. It might be that this has never been correctly tested. @ccollins476ad can you shed some light?

@carlescufi carlescufi added priority: low Low impact/importance bug Enhancement Changes/Updates/Additions to existing features and removed bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug labels May 14, 2019
@carlescufi
Copy link
Member

Relabeled as enhancement since this has never been actually supported. Contributors welcome to address this.

@pabigot
Copy link
Collaborator

pabigot commented Aug 22, 2020

It appears that when this was originally contributed in apache/mynewt-mcumgr@96dc9d8 it referenced a managed log infrastructure that was not part of the contribution. I can find no history of it ever being in Zephyr, nor elsewhere.

The dependency reference was removed from Zephyr in 4db7cce leaving the mistaken impression that CONFIG_MCUMGR_CMD_LOG_MGMT ever had a chance of working in Zephyr.

It would probably be good to remove the entire cmd/log_mgmt/port/zephyr hierarchy and everything referencing it from upstream mcumgr, and from Zephyr itself. It's continued presence (and marking as "currently disabled" in the Zephyr documentation without explanation) will confuse and waste the time of users interested in getting log information off a device.

de-nordic added a commit to de-nordic/zephyr that referenced this issue Sep 14, 2020
log related commands have never been supported by mcumgr on Zephyr.
This commit removes configuration options that might have been
misleading for developers.

Fixes zephyrproject-rtos#15713

Signed-off-by: Dominik Ermel <[email protected]>
@de-nordic de-nordic self-assigned this Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Device Management area: Logging Enhancement Changes/Updates/Additions to existing features
Projects
None yet
4 participants