Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build failure: several bluetooth samples fail to build on nrf51dk_nrf51422 #28774

Closed
galak opened this issue Sep 29, 2020 · 0 comments · Fixed by #28784
Closed

build failure: several bluetooth samples fail to build on nrf51dk_nrf51422 #28774

galak opened this issue Sep 29, 2020 · 0 comments · Fixed by #28784
Assignees
@cvinayak
Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug

Comments

@galak
Copy link
Collaborator

galak commented Sep 29, 2020

If I do:

./scripts/sanitycheck -p nrf51dk_nrf51422 -T samples/bluetooth/

I get:

ERROR   - nrf51dk_nrf51422          samples/bluetooth/hci_spi/sample.bluetooth.hci_spi FAILED: Build failure
ERROR   - see: /home/galak/git/zephyr/sanity-out/nrf51dk_nrf51422/samples/bluetooth/hci_spi/sample.bluetooth.hci_spi/build.log
INFO    - Total complete:    2/   4  50%  skipped:    0, failed:    1
ERROR   - nrf51dk_nrf51422          samples/bluetooth/hci_uart/sample.bluetooth.hci_uart.nrf5 FAILED: Build failure
ERROR   - see: /home/galak/git/zephyr/sanity-out/nrf51dk_nrf51422/samples/bluetooth/hci_uart/sample.bluetooth.hci_uart.nrf5/build.log
INFO    - Total complete:    3/   4  75%  skipped:    0, failed:    2
ERROR   - nrf51dk_nrf51422          samples/bluetooth/hci_uart/sample.bluetooth.hci_uart.arm FAILED: Build failure
ERROR   - see: /home/galak/git/zephyr/sanity-out/nrf51dk_nrf51422/samples/bluetooth/hci_uart/sample.bluetooth.hci_uart.arm/build.log

looking in logs:

/home/galak/git/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c: In function 'force_md_cnt_calc':
/home/galak/git/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c:6330:19: error: 'CONFIG_BT_CTLR_DATA_LENGTH_MAX' undeclared (first use in this function)
 6330 |  time_incoming = (CONFIG_BT_CTLR_DATA_LENGTH_MAX << 3) *
      |                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/galak/git/zephyr/subsys/bluetooth/controller/ll_sw/ull_conn.c:6330:19: note: each undeclared identifier is reported only once for each function it appears in
gmake[2]: *** [zephyr/subsys/bluetooth/controller/CMakeFiles/subsys__bluetooth__controller.dir/build.make:252: zephyr/subsys/bluetooth/controller/CMakeFiles/subsys__bluetooth__controller.dir/ll_sw/ull_conn.c.obj] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:3125: zephyr/subsys/bluetooth/controller/CMakeFiles/subsys__bluetooth__controller.dir/all] Error 2
gmake: *** [Makefile:104: all] Error 2
@galak galak added the bug The issue is a bug, or the PR is fixing a bug label Sep 29, 2020
@galak galak added area: Bluetooth priority: high High impact/importance bug labels Sep 29, 2020
@cvinayak cvinayak mentioned this issue Sep 29, 2020
Merged
cvinayak added a commit to cvinayak/zephyr that referenced this issue Sep 29, 2020
@cvinayak
Bluetooth: controller: Fix undeclared identifier
3b9efa6 
Fix undeclared CONFIG_BT_CTLR_DATA_LENGTH_MAX when Force
MD bit automatic feature is enabled in nRF51 Series.

Fixes zephyrproject-rtos#28774.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
galak pushed a commit that referenced this issue Sep 30, 2020
@cvinayak @galak
Bluetooth: controller: Fix undeclared identifier
48a0c0c 
Fix undeclared CONFIG_BT_CTLR_DATA_LENGTH_MAX when Force
MD bit automatic feature is enabled in nRF51 Series.

Fixes #28774.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvinayak cvinayak

Labels
area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bluetooth: controller: Fix undeclared identifier cvinayak/zephyr
2 participants
@cvinayak @galak