Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Dead links to sample source directories #28990

Closed
martinjaeger opened this issue Oct 7, 2020 · 3 comments · Fixed by #29004
Closed

Docs: Dead links to sample source directories #28990

martinjaeger opened this issue Oct 7, 2020 · 3 comments · Fixed by #29004
Assignees
Labels
area: Documentation bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug priority: medium Medium impact/importance bug

Comments

@martinjaeger
Copy link
Member

Links to sample source files point to docs.zephyrproject.org instead of github.com.

Example: https://docs.zephyrproject.org/latest/samples/net/gsm_modem/README.html

Link behind samples/net/gsm_modem points to:

https://docs.zephyrproject.org/blob/master/samples/net/gsm_modem

instead of:

https://github.com/zephyrproject-rtos/zephyr/blob/master/samples/net/gsm_modem

@martinjaeger martinjaeger added bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug area: Documentation labels Oct 7, 2020
@nashif nashif added the priority: medium Medium impact/importance bug label Oct 7, 2020
@nashif
Copy link
Member

nashif commented Oct 7, 2020

@utzig you recently made a change here (#28245), can you please take a look?

@utzig
Copy link
Member

utzig commented Oct 7, 2020

This seems to happen after the update to west==0.8.0; previously WestManifest.from_file().get_projects(['zephyr'])[0].url was None, now with 0.8.0 it is not anymore, so I'll check what changed there. Any tips @mbolivar-nordic?

@mbolivar-nordic
Copy link
Contributor

Any tips @mbolivar-nordic?

Looks like you figured it out from the API changes documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Documentation bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug priority: medium Medium impact/importance bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants