doc: ext: link-roles: allow non-default baseurl #28245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
ERROR - /workdir/zephyr/tests/benchmarks/footprints/testcase.yaml: can't load (skipping): <SchemaError: error code 2: Schema validation failed:
- Key 'arch_whitelist' was not defined. Path: '/tests/benchmark.kernel.footprints.userspace'.: Path: '/'>
CI errors look unrelated. Not sure if someone else sent the hotfix already.
utzig
force-pushed
the
link-roles-baseurl
branch
from
bc2d652 to
c8229b2
Compare
mbolivar-nordic
approved these changes
Sep 9, 2020
utzig
force-pushed
the
link-roles-baseurl
branch
from
c8229b2 to
e4495ae
Compare
Link roles, aka :zephyr_file: and :zephyr_raw: use a repo's git describe information to create links but the baseurl is fixed to the upstream repo. This breaks links created in repos that are forks located somewhere else. This commits tries to get the baseurl from west if available so it will work correctly for forks. If fallbacks to the upstream repo if no information can be gathered by West, or West is not available. Signed-off-by: Fabio Utzig <[email protected]>
carlescufi
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link roles, aka :zephyr_file: and :zephyr_raw: use a repo's git describe information to create links but the baseurl is fixed to the upstream repo. This breaks links created in repos that are forks located somewhere else.
This commits tries to get the baseurl from west if available so it will work correctly for forks. If fallbacks to the upstream repo if no information can be gathered by West, or West is not available.